Closed onuro closed 2 years ago
I think in patterns we need to stay away from defining text color if we're not also defining background color - in this pattern the text in the bottom right gets invisible on a site with a dark background.
I know Appleton had a slightly lighter color applied to the body text, but I think in a pattern we should stick to using the foreground color and drop that nuance, in favor of better adaptability across different themes.
@alaczek yeah I've been following that rule as well, avoiding custom text colors. Somehow I seem to have missed the custom color on that paragraph. Fixing shortly
Updated w color fix on that paragraph
Yes, this is better! One more thing I noticed is the explicitly set width on the group block - I would use wide or full width setting instead to better blend in.
Yep. Updated w custom width into wide-align.
Alright, then feel free to publish.
Let's reconsider the use of the vw
unit for the paddings in the area overlapping the image. The pattern loses its tension when it's viewed on a large monitor because of that.
I think I said this before, but it might be good to align the text on the left either vertically top or bottom instead of the centre it feels floating.
Tested with dark mode themes as well.
https://dotcompatterns.wordpress.com/?p=5727&preview=true