Closed alaczek closed 2 years ago
I wonder if we should define px values for font sizes in patterns for large text for better mobile view(see example). Or ignore since we're getting fluid typography soon?
How would switching to px values improve this design?
We can implement fluid typography when we're bundling these with the theme, but not for stand-alone patterns.
I mean a mobile first px size that will play well in mobile but yeah, fluid typo might be the wait for.
I'm wondering why the line breaks are happening here, but not in https://github.com/Automattic/blockpatterns/issues/243 where we could really use them? Any ideas?
I updated the code to optimize the spacing around the pattern on mobile (there was too much horizontal space). I also made the link's font size slightly smaller (from 4 to 3,8 rem) and increased the line-height to 1,5. And finally, I added a spacer after the paragraph on the left, so that there's some breathing room between the two on mobile. I feel like this gives us a good balance of mobile optimization while staying true to the design.
Published!
Preview: https://dotcompatterns.wordpress.com/?p=5869