Also, I used this chance to modularize and DRY up the focus management for our AppNavbar and the SegmentedControl, because they're effectively the same!
The AppNavbar also now has a much more iterative structure that should make it easy to extend in the future! 🎉
Testing Instructions
[ ] Unit tests still pass
[ ] Try tabbing into the various segmented controls and the top app navbar, and play around with the keyboard arrows!
What Does This PR Add/Change?
Previously, our
SegmentedControlcomponent didn't meet the WAI ARIA keyboard specs for horizontallistboxes: https://www.w3.org/WAI/ARIA/apg/patterns/listbox/Now it does!
Also, I used this chance to modularize and DRY up the focus management for our
AppNavbarand theSegmentedControl, because they're effectively the same!The
AppNavbaralso now has a much more iterative structure that should make it easy to extend in the future! 🎉Testing Instructions
Issues
Related to #
Closes #81