Automattic / bugomattic

Bugomattic is a tool that guides bug reporters to the right actions within large, complex organizations
GNU General Public License v2.0
6 stars 0 forks source link

Tree Performance Round 2: Add character limit for feature search #136

Closed karenroldan closed 1 year ago

karenroldan commented 1 year ago

What Does This PR Add/Change?

This is part of optimizing the performance of the feature search.

When searching for a feature, there is now a minimum of 3 characters to trigger the search. The behavior is similar when searching for issues:

Testing Instructions

Issues

Related to #134 Closes #

dpasque commented 1 year ago

@karenroldan This is fantastic!! This makes me realize I was probably way over-thinking this too haha... Having the debounce limit avoids the more silly cases while still allowing people to override it!

I tweaked the debounce time back to 300ms btw -- from research online, this seems more in the range of what it should be for a quick client-side search. I wanted to avoid too long too because we don't have a loading indicator!

I'm going to merge this FYI!

Thank you again -- this feels really good and makes a big difference! 🚀

FYI to @john-legg that this is how we're helping getting around the silly one-letter searches