Closed dpasque closed 1 year ago
Nice work, Dan! I tested a few things to make sure the flip didn't cause any unwanted issues, but I didn't find anything major. The new warning/error icon works really well and it makes it more distinguishable from the other icons. I'm glad you and Brie suggested it!
nitpick (non-blocking):
One very minor thing that I noticed during VoiceOver is that reading over the Type and Title form reads the non-flipped version still: set issue title and type
.
suggestion (non-blocking): I definitely think the Title tooltip could be slightly reworded to be more concise. However, I'm terrible at website copy, so I don't have a suggestion on alternatives 😅 I'll try to think of something and get back to you!
One very minor thing that I noticed during VoiceOver is that reading over the Type and Title form reads the non-flipped version still: set issue title and type.
Ooo, nice catch! I also just went and found even more code naming conventions I missed, oops! These are all fixed now 😁
What Does This PR Add/Change?
Ignore the many files, this is actually a relatively small change! (But reference updates touched a lot of files).
This makes the following updates:
Testing Instructions
Unit tests should still pass and flow should still work as normal!
Main piece of feedback: what do you think of the title tooltip text? Any suggestions?
Issues
Related to #
Closes #