Closed dpasque closed 1 year ago
@dpasque this looks good! Lots of great changes 👏
Everything works as expected and I especially like the new highlighting style for feature searching -- it looks way better. I added a few copy-related nitpicks that are super minor, but I'll go ahead and approve it in case you need to move forward with it 🚀
I also had a few ideas I wanted to run by you in a Slack thread, so look out for that soon!
Alright @john-legg, everything should now be up to date with your design! 👍 (including adding More Info back in). Let me know what other changes and tweaks I should make! 😄
@dpasque this is awesome! Thanks for making these changes so quickly. I know I threw extra stuff your way today 😬
I finished the accessibility testing and everything works as expected. I especially like how it immediately reads the "missing information" and "no reporting configuration" error messages as soon as it lands on the page 👏
suggestion (non-blocking): Two final tweaks I'd like to suggest are:
max-width
of .badStateImage
just a bit. I put 400px
and it looked good.2rem
and that seemed about right.Other than that, I think this PR is ready. Feel free to merge whenever you want 🚀
Thanks for making these changes so quickly. I know I threw extra stuff your way today 😬
@john-legg thank YOU for all the great feedback as always -- these look sooooooo much nicer now! I really appreciate all your input, never hold back, please! 😁
What Does This PR Add/Change?
This PR is a grab-bag of the smaller fixes that came out of our usability testing. See pciE2j-1Pp-p2 for context.
Fixes include...
overflow-x
actually changes the default behavior ofoverflow-y
!)Testing Instructions
yarn start
and play around with the changes!Issues
Related to #
Closes #