Automattic / bugomattic

Bugomattic is a tool that guides bug reporters to the right actions within large, complex organizations
GNU General Public License v2.0
6 stars 0 forks source link

Remove the title field from the form #52

Closed karenroldan closed 1 year ago

karenroldan commented 1 year ago

What Does This PR Add/Change?

Deleted the Title field. Context: pciE2j-1VQ-p2#comment-1674

Screenshot 2023-03-31 at 10 52 02

Key changes:

  1. Updated all names from Type and Title to Type only.
  2. Updated the tests to reflect the name changes.
  3. Updated the tests to verify Type only.

Testing Instructions

I've manually tested the changes and updated the tests!

Issues

Related to #
Closes #

dpasque commented 1 year ago

@karenroldan -- this looks great, thank you so much! 😄 This kind of PRs can be the worst because it is so many small updates! I really appreciate it 🙇

Overall, the changes look great!

As I'm looking at this, I wonder if we should keep the issue title in the redux state and URL tracking (and pass it along to GitHub links) even though we remove it from all the places in the UI?

I feel like that could open up some cool potential use cases in the future, where maybe we seed the issue title with their most recent duplicate search phrase. Or we could do integrations like making a link in HappyChat that seeds Bugomattic with an issue title? Or really anything like that.

What do you think @karenroldan and @john-legg?

dpasque commented 1 year ago

Also, one tiny adjustment - comparing to the mockups, I wonder if we should drop the margin a little bit on the Type fieldset?

.typeFieldset {
    border: none;
    margin: 0 0 2.5rem 0;
    padding: 0;
}

From playing around, I think dropping the bottom margin ☝️ there to 1rem looked a little more like the mockups. Does that sound right @john-legg?

karenroldan commented 1 year ago

I feel like that could open up some cool potential use cases in the future, where maybe we seed the issue title with their most recent duplicate search phrase. Or we could do integrations like making a link in HappyChat that seeds Bugomattic with an issue title? Or really anything like that.

I think that's a good idea! It's always better to have it available so we can extend the functionality! I'll put those back. 👍🏻

karenroldan commented 1 year ago

All good!

I've added back the issue title in the redux state and URL tracking! The fix can be found here: 519ea51

I've also updated the bottom margin from 2.5rem to 1rem. The fix can be found here: ac56216

/cc: @john-legg @dpasque

dpasque commented 1 year ago

@karenroldan -- thank you so much for the updates, they look awesome! 😄

When I was running/looking at the unit tests locally, I noticed a couple had type warnings for the missing issueTitle so I just added those back in real quick in 511ebcc - I hope that's okay! 🙇

karenroldan commented 1 year ago

When I was running/looking at the unit tests locally, I noticed a couple had type warnings for the missing issueTitle so I just added those back in real quick in 511ebcc - I hope that's okay! 🙇

Thanks a lot, @dpasque! I don't see the warnings when running the unit tests locally. 😞 I run using yarn test and pressed a to run all tests. Do I need to set something else?

I'll go ahead and merge this. Thanks for reviewing, John and Dan!