Closed karenroldan closed 1 year ago
I'm also realizing that a lot of these suggestions (both design and code refactor) might need further discussion or clarification, so please just feel free to spin up a Slack thread if it would be more helpful to discuss these! 🙂 👍
I'm also realizing that a lot of these suggestions (both design and code refactor) might need further discussion or clarification, so please just feel free to spin up a Slack thread if it would be more helpful to discuss these! 🙂 👍
Yeah, a Slack thread might be a good idea! I'll go ahead and start one 👍
I feel so bad asking this after @karenroldan did such a nice job implementing it, but I'm wondering if we should literally just display the phrase "description match" in the pill without showing any keywords or scores. This is less information, but I think it makes the tree look less overwhelming, prevents wrapping in most cases, and also lets us simplify a lot of the code!
Don't worry about it! I like that we can keep on iterating and explore on different ideas. Let's continue to weigh the pros and cons and find the best solution! 💡
We can continue our discussion in this Slack thread: p1683670129349769-slack-CQD1HH4MA
What Does This PR Add/Change?
This PR now displays the description matches! 🎉
Key changes:
reporting-config-search-results.tsx
and separated it into more readable functions.Testing Instructions
Issues
Related to #
Closes #