Closed dpasque closed 1 year ago
@worldomonation Awesome! 😄 Thanks for taking a look!!
You've gone from camelCase URL to a dash-case(?) format instead. I think that does make it easier to read in the context of URLs.
Yep, that's a big change! Probably the biggest one though is not tracking the falsy or default values -- mostly this just keeps the number of query params appended to the end to a much smaller number except in really complicated case. I think this will help people feel more comfortable learning all the query params! And it makes conceptual sense: as you add meaningful data to the app, the URL gets correspondingly longer and more data rich (rather than just all at once)
What Does This PR Add/Change?
Don't ya just hate when you go to Bugomattic, make one teeny, innocent change, and then get steamrolled by a URL that looks like the green symbols from the Matrix? I sure do!
It's time to make our state-tracking URL more user-friendly!
**Note, these changes are actually quite small. I just updated some static string values, and that corresponded to a lot of file updates!
Here's how our URL is now better:
activePage
and theactiveReportingStep
. (These feel more like navigation values, so hiding the default felt weird. Although I feel that way much more so aboutactiveStep
thanactiveReportingStep
. What do you think?)IssueType
andActivePage
) and switched from camelCase values to kebab-case values. I think that will be more user-friendly for manual editing!Testing Instructions
Note: the search term appears to be borked, and was so before this change. I've written up the issue in #93 and will fix it in another PR 👍
Issues
Related to #
Closes #69