Closed dpasque closed 1 year ago
Woo! This is awesome, Dan. I think this will help tremendously with tree exploration 👏
suggestion (if-minor): Would you be open to making the resize target the entire horizontal divider instead of just the corner icon? Something like a handlebar functionality? I found the resize icon a little harder to discover and click -- especially on mobile. That's just my opinion though!
Hey @john-legg! 😄
Would you be open to making the resize target the entire horizontal divider instead of just the corner icon? Something like a handlebar functionality? I found the resize icon a little harder to discover and click -- especially on mobile. That's just my opinion though!
Alas, I 100% couldn't agree more, but this is not a cheap change sadly. 😕 Right now we're just using the native css resize
, which is great because it's completely native and cheap (it's like 2 lines of css code! 😲 ), but it doesn't offer a lot of customizability.
To do a handlebar thing, we'd have to roll a JS/TS based resizer which adds quite a lot more complexity. 😕 I sadly don't think the tradeoff is there for this one!
What Does This PR Add/Change?
This make the feature tree vertically resizable! This should help users who want to do manual exploration of the tree.
Along with that, there were a couple of tiny css tweaks:
rem
above the bottom panelTesting Instructions
Play around with it!
Issues
Related to #
Closes #