search

Automattic / camptix

Moved to https://github.com/WordPress/wordcamp.org/
176 stars 94 forks source link

Allow wrapping subpages #199

Closed EliW closed 6 years ago

EliW commented 6 years ago

I've added a new option to the settings for whether people want the subpages (checkout screen, attendee screen, etc) to have the template blown away like the original code did. Or whether you still want the output wrapped in the standard template/page that otherwise this checkout existed in.

coreymckrill commented 6 years ago

Hi @EliW, it appears that this PR somehow also includes the changes in #193. Could you update the patch to keep the changes separate?

Also, could you explain more about what this patch does?

EliW commented 6 years ago

Ack, sorry about the double include there @coreymckrill - I'll take a look at how to remove that.

As far as what the patch does ... By default after your initial 'pick your tickets' screen that is created by the plugin, for all subsequent screens, camptix blows away any content that the page originally had on it. via: $post->post_content = $this->shortcode_str;

What this plugin does, is allow you the option to stop this from happening. In case you, in fact, prefer to still have the content of the post exist around the shortcode content, instead of only seeing the shortcode content.

EliW commented 6 years ago

OK, took a bit (my rebase/revert/reset/cherrypick skills aren't quite up to task it seems) ... But I've cleaned it up so that this just includes the wrap-subpages change.

EliW commented 6 years ago

Thanks for all the feedback on this one (and other PR's I'd submitted). Now that the new version is out, I'm rebasing a few pulls and doing things the 'camptix way'.

Closing this one, new version of this incoming.