search

Automattic / camptix

Moved to https://github.com/WordPress/wordcamp.org/
176 stars 94 forks source link

Currency: add fallback for system without strfmon #214

Closed indralukmana closed 6 years ago

indralukmana commented 6 years ago

Systems without strfmon capability will throw an error when using money_format function (such as Windows).

In this commit the currency fallback into a simple currency symbol and price.

The price currency symbol in some currency system however still not correctly displayed as windows have different locale system. Manual formatting then used for this.

virtualbox_windows 10_22_06_2018_08_38_42

The currencies symbol and format, however, will not show the exact same formatting when compared with other systems (such as in Mac).

screen shot 2018-06-22 at 08 38 21

This is for solving the issues #153 Related with PR #85

vedanshujain commented 6 years ago

Closing this in favor of https://github.com/Automattic/camptix/pull/222 . ( I have cherry-picked your commit there )