search

Automattic / camptix

Moved to https://github.com/WordPress/wordcamp.org/
177 stars 97 forks source link

Camptix Stripe bug-fix (.unique() vs .uniqueSort()) #232

Open EliW opened 5 years ago

EliW commented 5 years ago

This was a PR I'd submitted to the original stripe plugin, but never got accepted there before the code was merged here into the main camptix:

The Stripe plugin uses jQuery.uniqueSort(), however, that function only exists in jQuery 3.x which many themes and even WordPress itself doesn't use or include. Changing this to just .unique() which is aliased in 3.x and works in 2.x as well for greater compatibility. Otherwise lots of people will end up getting failures when trying to use Stripe.

EliW commented 5 years ago

ping ... Just realizing that it's been months and this hasn't been pulled in. Seems like a pretty important fix?