search

Automattic / chatrix

Matrix client for WordPress
https://wordpress.org/plugins/chatrix
GNU General Public License v2.0
41 stars 0 forks source link

Height unit selector #154

Closed psrpinto closed 1 year ago

psrpinto commented 1 year ago

Fixes #137

This PR makes it possible to change the unit of fields, as opposed to the unit being hardcoded to px.

Screen capture

Screenshot 2023-01-11 at 15 28 34
psrpinto commented 1 year ago

This is mostly done, but there's an issue where the Resizable box does not correctly follow the height of the block, when certain styling changes its height (e.g. border-width). I'm working on addressing this issue.

Screenshot 2023-01-11 at 15 05 32
psrpinto commented 1 year ago

The issue mentioned above is also present on the main branch so it's not introduced by this PR. I've opened #162 to track it so that this PR can move forward.