Automattic / chatrix

Matrix client for WordPress
https://wordpress.org/plugins/chatrix
GNU General Public License v2.0
41 stars 0 forks source link

Handling a private room in single room mode #208

Open ashfame opened 1 year ago

ashfame commented 1 year ago

As of now, we show the unknownRoomView, which has the text "Want to join it?" which doesn't make sense.

Screenshot 2023-03-24 at 11 49 38 AM

Should we redirect to login view? It could be the case user won't have access even after logging in, so should we perhaps present the button to go to login? We can also add more text to describe the possible outcomes.

akirk commented 1 year ago

Could you maybe explain with a screenshot? Why doesn't the text "Want to join it" make sense?

ashfame commented 1 year ago

@akirk I added a screenshot in the top comment. Its because the guest user or even the logged in user, can't just join a private room. They need to be invited.

akirk commented 1 year ago

Ok understood. In the description there was no mention of the private room and I somehow skipped reading the headline.

Can you detect that the room cannot be joined? What about adding exactly what you said: "You need to be invited to be able to join"

ashfame commented 1 year ago

No worries, I was just making a quite note for later. Yeah, some description note based on what type of room this is, we can say something that includes both cases:

ashfame commented 1 year ago

Related: #181