Automattic / chatrix

Matrix client for WordPress
https://wordpress.org/plugins/chatrix
GNU General Public License v2.0
41 stars 0 forks source link

Allow navigating away from unknown room view #213

Closed ashfame closed 1 year ago

ashfame commented 1 year ago

In this PR:

Header with back arrow link shown now Screen shown after you click the back arrow
Screenshot 2023-03-31 at 12 18 14 AM Screenshot 2023-03-31 at 12 18 25 AM
ashfame commented 1 year ago

@psrpinto Build currently fails because it doesn't have that temporary fix we did in Hydrogen for skipping manifest.json

diff --git a/Users/ashfame/git/hydrogen-web/scripts/build-plugins/service-worker.js b/Users/ashfame/git/chatrix/node_modules/hydrogen-web/scripts/build-plugins/service-worker.js
index 0b66c88..0f52f26 100644
--- a/Users/ashfame/git/hydrogen-web/scripts/build-plugins/service-worker.js
+++ b/Users/ashfame/git/chatrix/node_modules/hydrogen-web/scripts/build-plugins/service-worker.js
@@ -73,6 +73,10 @@ const NON_PRECACHED_JS = [
 function isPreCached(asset) {
     const {name, fileName} = asset;

+    if ( !name ) {
+        return false;
+    }
+
     // For sync-worker.js and sync-worker.js.map, `name` isn't set, so we must rely on `fileName` only.
psrpinto commented 1 year ago

@ashfame https://github.com/Automattic/chatrix/pull/214 fixes the build issue. Once that one gets merged to main, we can rebase this on main and it should build.

psrpinto commented 1 year ago

I rebased with main to get the build fixes, didn't make any other changes.