Closed ashfame closed 1 year ago
@psrpinto Build currently fails because it doesn't have that temporary fix we did in Hydrogen for skipping manifest.json
diff --git a/Users/ashfame/git/hydrogen-web/scripts/build-plugins/service-worker.js b/Users/ashfame/git/chatrix/node_modules/hydrogen-web/scripts/build-plugins/service-worker.js
index 0b66c88..0f52f26 100644
--- a/Users/ashfame/git/hydrogen-web/scripts/build-plugins/service-worker.js
+++ b/Users/ashfame/git/chatrix/node_modules/hydrogen-web/scripts/build-plugins/service-worker.js
@@ -73,6 +73,10 @@ const NON_PRECACHED_JS = [
function isPreCached(asset) {
const {name, fileName} = asset;
+ if ( !name ) {
+ return false;
+ }
+
// For sync-worker.js and sync-worker.js.map, `name` isn't set, so we must rely on `fileName` only.
@ashfame https://github.com/Automattic/chatrix/pull/214 fixes the build issue. Once that one gets merged to main
, we can rebase this on main
and it should build.
I rebased with main
to get the build fixes, didn't make any other changes.
In this PR:
UnknownRoomViewModel
class to define a differentcloseUrl()
for single room mode