search

Automattic / cli-table

Pretty unicode tables for the CLI with Node.JS
MIT License
2.28k stars 141 forks source link

adding publish-please to dependencies seems to be causing downstream problems #129

Closed jphelps413 closed 3 years ago

jphelps413 commented 3 years ago

Expected/Desired Behavior

Should be able to run npm-check-updates with having publish-please kick in

Fill with either one:

It seems that the addition of publish-please to the dependencies is now causing our downstream repositories to have publish-please foisted upon them. Locking cli-table to v0.3.1 avoids the problem, but that's not ideal.

  1. Expected behavior for bugs
  2. Desired behavior for improvements/enhancements

Actual Behavior

How does the application currently work.

Steps to Reproduce the Problem/Current behavior

  1. Step 1
  2. Step 2
  3. Step 3

(Optional) Additional notes and links

Any other relevant informations helping in debugging/implementing.

PeledYuval commented 3 years ago

+1 This happens for us too. All builds are failing.

I don't understand why "publish-please" is a dependency and not a devDependency for this package, am I missing something or is this just an oversight by the maintainer?

PeledYuval commented 3 years ago

Here's a PR that fixes this: https://github.com/Automattic/cli-table/pull/130

joamag commented 3 years ago

I'm also having issues with builds related to the fact that publish-please is being included as a dependency

atao60 commented 3 years ago

+1 Break down @webpack-cli/init@1.0.3 (published one month ago!)

jrstnly commented 3 years ago

+1 Breaks firebase-tools installation

jphelps413 commented 3 years ago

While we're on the subject, should the babel dependencies also be moved into devDependencies?

thanhtoan1196 commented 3 years ago

I got an error while using semantic-release

➜  project git:(master) yarn add -D semantic-release@17.3.0
yarn add v1.22.10
[1/4] 🔍  Resolving packages...
warning semantic-release > @semantic-release/npm > npm > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning semantic-release > @semantic-release/npm > npm > node-gyp > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning semantic-release > @semantic-release/npm > npm > request > har-validator@5.1.5: this library is no longer supported
warning semantic-release > marked-terminal > cli-table > publish-please > cp-sugar > cross-spawn-async@2.2.5: cross-spawn no longer requires a build toolchain, use it instead
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > cogo-toast@4.2.3" has unmet peer dependency "prop-types@^15.6.2".
warning "next > use-subscription@1.5.0" has incorrect peer dependency "react@^17.0.0".
warning "next-optimized-images > file-loader@3.0.1" has unmet peer dependency "webpack@^4.0.0".
warning "next-optimized-images > raw-loader@2.0.0" has unmet peer dependency "webpack@^4.3.0".
warning "next-optimized-images > url-loader@1.1.2" has unmet peer dependency "webpack@^3.0.0 || ^4.0.0".
warning " > tailwindcss@2.0.1" has unmet peer dependency "autoprefixer@^10.0.2".
warning " > @tailwindcss/custom-forms@0.2.1" has incorrect peer dependency "tailwindcss@^1.0".
warning " > postcss-prefixwrap@1.19.0" has incorrect peer dependency "postcss@7.*.*|^8.1.0".
warning " > tailwindcss-debug-screens@1.1.0" has incorrect peer dependency "tailwindcss@^1.0".
[4/4] 🔨  Building fresh packages...
error /Users/toan/Desktop/project/node_modules/publish-please: Command failed.
Exit signal: SIGINT
Command: node lib/post-install.js
Arguments: 
Directory: /Users/toan/Desktop/project/node_modules/publish-please
Output:
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! publish-please hooks were successfully setup for the project. !!
!! Now follow few simple steps to configure your publishing...   !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

-- Configuring option "prePublishScript":
? Do you want to run any scripts before publishing (e.g. build steps, tests)? (Y
/n) 
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
chrean commented 3 years ago

Sorry about this and thanks for the PR, #130 merged and new release pushed out. My bad.

chrean commented 3 years ago

FYI v0.3.2 has been deprecated on npm. I suggest bumping to 0.3.4 which also reverts Node support to 10+ (was 12+).