search

Automattic / cli-table

Pretty unicode tables for the CLI with Node.JS
MIT License
2.28k stars 141 forks source link

`colors` package update would improve webpack compatibility #146

Open Mr-Wallet opened 3 years ago

Mr-Wallet commented 3 years ago

I'm trying to include this module in a project with webpack, which tries to gather up code into discrete bundles. It can't do this if it can't figure out where a require is likely to lead.

Older versions of colors included a setTheme method that took an arbitrary string and then tried to require that string directly, i.e. literally anything could possibly be required from literally anywhere... so webpack is in a bind. This was resolved several years ago in colors, and hopefully that dependency could be updated in the next release of cli-table.

I would have already opened a pull request myself today, but colors doesn't keep a changelog and I'm not sure how it's being used in this package, so I'm afraid of breaking something.

schuerg commented 2 years ago

Do not update colors npmjs package to >=1.4.1.

See https://security.snyk.io/vuln/SNYK-JS-COLORS-2331906

DABH commented 2 years ago

This issue could be closed in favor of #167, which has effectively the same solution (https://github.com/Automattic/cli-table/pull/169) cc @chrean