The default placeholder on the feedback form front end for email says "your email (optional)" even if the email field is required. This only happens when the default placeholder is left in place, any changes to the place holder in the editor overrides the default (optional) text.
It looks like at some point the attributes.js for the block was corrected to remove that (which is why it doesn't show in the editor). However, this block also pulls attributes from a .php file for the front end, which still had the optional wording.
I've corrected the wording in the PHP file as well as the translation file (crowdsignal-forms.pot)
Testing:
build this plugin on a test site, and then create a new post/page and add the feedback block. Preview the post and click the feedback button. Verify that Optional doesn't show up.
This is a fix for https://github.com/Automattic/crowdsignal-forms/issues/99
The default placeholder on the feedback form front end for email says "your email (optional)" even if the email field is required. This only happens when the default placeholder is left in place, any changes to the place holder in the editor overrides the default (optional) text.
It looks like at some point the attributes.js for the block was corrected to remove that (which is why it doesn't show in the editor). However, this block also pulls attributes from a .php file for the front end, which still had the optional wording.
I've corrected the wording in the PHP file as well as the translation file (crowdsignal-forms.pot)
Testing:
build this plugin on a test site, and then create a new post/page and add the feedback block. Preview the post and click the feedback button. Verify that Optional doesn't show up.