search

Automattic / default-small-business-theme

GNU General Public License v2.0
10 stars 7 forks source link

Business editor styles rewrite #19

Closed mendezcode closed 5 years ago

mendezcode commented 5 years ago

Overview

This is a complete rewrite of the editor styles for the Business theme.

The previous styles have been completely discarded and the new editor styles have been created from scratch. Several of the reported issues have already been fixed by this rewrite.

Also, the enqueuing of editor styles has been refactored to remove the redundancy (as reported in #15), which was causing all the trouble in the editor styles currently.

The code uses the work by @laurelfulford on Automattic/theme-tools, which provides a good starting point for the editor styles.

Related issues: #10, #12, #13, #14, #15

Installation Instructions

Start by cloning the branch:

git clone --depth=1 git@github.com:Automattic/default-small-business-theme.git -b fix/base-editor-styles

Install dependencies and build theme:

make deps build

At this point, theme should be ready for testing.

Testing Instructions

Use the testing approach of your preference.

Our gutenberg-test-data can be used for testing.

alaczek commented 5 years ago

Great job on the re-write!

Related issues: #10, #12, #13, #14, #15

These are fixed from my testing.