search

Automattic / dops-components

Shared Calypso-style components for non-Calypso projects.
GNU General Public License v2.0
9 stars 6 forks source link

Update dependencies and fix eslint errors #109

Closed gravityrail closed 7 years ago

gravityrail commented 7 years ago

I was launching a new project that depends on dops-components, so I decided to ncu and fix the compile errors etc.

This is still a WIP, but comments/thoughts welcome.

gravityrail commented 7 years ago

@ryelle thanks for the feedback. In terms of updating to reflect style issues etc. I'd rather do that in another PR, since this one is already so large and those problems existed prior to doing the dependency updates.

Similar regarding eslint fixes. I agree it's far from ideal to be putting eslint-disable all over the place, but fixing all those issues (which already existed before this PR) feels like I'd be introducing more changes than could be reasonably tested, e.g. new interaction bugs etc. Definitely worth addressing those in separate patches and eventually eliminating them, but they're not regressions and at least now we know where we have work to do!