Fix errors highlighted by akismet-react app

Automattic / dops-components

Shared Calypso-style components for non-Calypso projects.

GNU General Public License v2.0

9 stars 6 forks source link

Fix errors highlighted by akismet-react app #31

Closed eoigal closed 8 years ago

eoigal commented 8 years ago

Dops-components repo is being used by the akismet-react repo but due to recent changes this repo is no longer compatible.

This PR will fix bugs found while trying to make the 2 repos compatible. The PR on akismet-react can be found here.

gravityrail commented 8 years ago

Good catches.

cfinke commented 8 years ago

Can this get fixed and merged? akismet-react is unusable by anyone who doesn't already have a custom development workflow set up until these conflicts are resolved.

ryelle commented 8 years ago

Most of these issues have been merged in other PRs, the only remaining issues preventing Akismet from building are now addressed in #71

eoigal commented 8 years ago

Agree with @ryelle, this can be closed as any issue left should be addressed in #71