Closed davewhitley closed 7 years ago
Design is good, SVG is good. 👍
GitHub is saying there are conflicts tho, which is odd.
Hm, looks like there is a grunt task that injects the svg sprite in the index.html files.
This commit deletes the svg sprite and adds a function, but probably did not remove the grunt task:
https://github.com/Automattic/gridicons/commit/73ef60aa31499f806055ca600fc3c13df018a4f7
@keoshi it looks like your function here generates the svg sprite:
but you may have forgotten to remove the grunt task that also generates it. Does that sound right?
If so, I guess we don't need the grunt task anymore?
@drw158 That's the SVG for Everybody function that uses a polyfill when supporting older browsers, not a grunt task. Not sure what the problem is, but I'm happy to help if you give me more details.
~I also just noticed, title in the SVG is 1Artboard 1
.~
Nevermind: I was checking the wrong commit.
Thanks @keoshi, it was might fault. I was working off of an old master!
All good, 🚢
thanks!
closes #201