Automattic / gridicons

The WordPress.com icon set
http://automattic.github.io/gridicons/
GNU General Public License v2.0
112 stars 13 forks source link

New icon: next page #208

Closed davewhitley closed 7 years ago

davewhitley commented 7 years ago

closes #201

screen shot 2017-05-24 at 12 15 28 pm screen shot 2017-05-24 at 12 15 03 pm screen shot 2017-05-24 at 12 14 54 pm

screen shot 2017-05-24 at 12 19 25 pm

folletto commented 7 years ago

Design is good, SVG is good. 👍

GitHub is saying there are conflicts tho, which is odd.

davewhitley commented 7 years ago

Hm, looks like there is a grunt task that injects the svg sprite in the index.html files.

This commit deletes the svg sprite and adds a function, but probably did not remove the grunt task:

https://github.com/Automattic/gridicons/commit/73ef60aa31499f806055ca600fc3c13df018a4f7

@keoshi it looks like your function here generates the svg sprite:

https://github.com/Automattic/gridicons/blob/73ef60aa31499f806055ca600fc3c13df018a4f7/svg-sprite/index.html#L86

but you may have forgotten to remove the grunt task that also generates it. Does that sound right?

If so, I guess we don't need the grunt task anymore?

keoshi commented 7 years ago

@drw158 That's the SVG for Everybody function that uses a polyfill when supporting older browsers, not a grunt task. Not sure what the problem is, but I'm happy to help if you give me more details.

folletto commented 7 years ago

~I also just noticed, title in the SVG is 1Artboard 1.~

Nevermind: I was checking the wrong commit.

davewhitley commented 7 years ago

Thanks @keoshi, it was might fault. I was working off of an old master!

folletto commented 7 years ago

All good, 🚢

davewhitley commented 7 years ago

thanks!