Automattic / gridicons

The WordPress.com icon set
http://automattic.github.io/gridicons/
GNU General Public License v2.0
112 stars 13 forks source link

Remove babel transform-runtime plugin #213

Closed gwwar closed 7 years ago

gwwar commented 7 years ago

Fixes #212

I had copy pasta'd the Calypso config, and missed that https://babeljs.io/docs/plugins/transform-runtime/ requires a hard dependency of babel-runtime. I went ahead and removed it since I'm not sure if we need these polyfills

For testing convenience, I published this to 1.1.0-alpha.1. So you can install this via: npm install gridicons@next --save

cc @aduth @sirbrillig

aduth commented 7 years ago

Do we need the runtime polyfills?

https://www.diffchecker.com/TsUjTIyo

I'm thinking... probably not. If anything, ES5+ on Object.create and Object.getPrototypeOf.

gwwar commented 7 years ago

See also https://github.com/Automattic/wp-calypso/pull/14531

gwwar commented 7 years ago

Alright, I tested a bit and I think we'll be okay with this change. I'm going to go ahead and merge this, then publish 1.1.0

gwwar commented 7 years ago

@sirbrillig 1.1.0 is now available, so we can install via npm install gridicons@latest --save or npm install gridicons@1.1.0 --save