search

Automattic / gridicons

The WordPress.com icon set
http://automattic.github.io/gridicons/
GNU General Public License v2.0
110 stars 13 forks source link

Build: Update example site with display controls #227

Closed davewhitley closed 7 years ago

davewhitley commented 7 years ago

This adds some display options to the example site.

I just remembered that these changes need to be moved to the build script.

screen shot 2017-06-19 at 12 31 27 pm

folletto commented 7 years ago

I think the changes need to be added here: https://github.com/Automattic/gridicons/blob/master/Gruntfile.js#L57

I plan to refactor that as an external template in a PR I've upcoming, so it's clearer where the code is coming from instead of being mashed inside the Gruntfile.js, but we can do this change first. 👍

davewhitley commented 7 years ago

Ok! I've moved the changes to the gruntfile, but when I run grunt, for some reason all of the svgs in svg-min get regenerated. Looking into it now.

Never mind, must have been a glitch with the GitHub app UI. Ran grunt and committed. 👍

folletto commented 7 years ago

I tried to rebuild everything, looks good. No diffs. The page also loads as expected.

🚢