Closed folletto closed 7 years ago
FWIW, I ran a diff for index.jsx
and example.jsx
and they match.
everything seems to work 👍
Did we forget to check in pdf/gridicons-nametag.pdf ? I see this as modified when I run npm install.
Yes: 704839da512f4003457249af9c346af8abb7359e
For folks 👀 we don't need a global grunt installed, the equivalent script that uses grunt from node_modules is npm run build
Ok done:
@folletto would you be interested in also updating the social-logos build? We'd be able to get rid of the handlebars dependency then
Ok, added to my todo list :)
Refactoring of social logos build PR: https://github.com/Automattic/social-logos/pull/58
This PR:
Why?
Note: there's also one icon added as PDF as it was added before we had the automated PDF build introduced in #238.
How to test
grunt