Automattic / gridicons

The WordPress.com icon set
http://automattic.github.io/gridicons/
GNU General Public License v2.0
111 stars 13 forks source link

Build: refactor tasks to file, demo template #241

Closed folletto closed 7 years ago

folletto commented 7 years ago

screen shot 2017-07-21 at 16 29 35

This PR:

Why?

  1. Easier to spot what changed in the build process
  2. More easily reused across different repositories (Gridicons, Social Icons, Dashicons)
  3. Cleaner separation of dependencies
  4. Folder and files input declared in config instead of being hardcoded
  5. Separate demo template
  6. Separate react template

Note: there's also one icon added as PDF as it was added before we had the automated PDF build introduced in #238.

How to test

  1. Switch to this branch
  2. grunt
  3. Check no changes to any built file anywhere, with the exception of the tabulation of the demo.
  4. Check the compiled React component works.
folletto commented 7 years ago

FWIW, I ran a diff for index.jsx and example.jsx and they match.

davewhitley commented 7 years ago

everything seems to work 👍

gwwar commented 7 years ago

Did we forget to check in pdf/gridicons-nametag.pdf ? I see this as modified when I run npm install.

folletto commented 7 years ago

Yes: 704839da512f4003457249af9c346af8abb7359e

gwwar commented 7 years ago

For folks 👀 we don't need a global grunt installed, the equivalent script that uses grunt from node_modules is npm run build

folletto commented 7 years ago

Ok done:

  1. Updated to master
  2. Cleaned up the missing ";".
gwwar commented 6 years ago

@folletto would you be interested in also updating the social-logos build? We'd be able to get rid of the handlebars dependency then

folletto commented 6 years ago

Ok, added to my todo list :)

folletto commented 6 years ago

Refactoring of social logos build PR: https://github.com/Automattic/social-logos/pull/58