search

Automattic / gridicons

The WordPress.com icon set
http://automattic.github.io/gridicons/
GNU General Public License v2.0
111 stars 13 forks source link

Build: update svg-to-pdfkit to 0.1.3 (exact) #258

Closed folletto closed 7 years ago

folletto commented 7 years ago

During #254 we noticed that when @iamthomasbishop tried to build, he got also all the PDF re-generated as different. This shouldn't happen — so after fixing the PR we tried to identify the issue.

Apparently, SVG-to-PDFKit updated to 0.1.3, thus changing some calculations on how the PDF was generated.

As it seems it's not a deterministic calculation, this PR:

  1. Updates svg-to-pdfkit to 0.1.3
  2. Fixes the svg-to-pdfkit library to a specific version, so when we decide to update it's manual and won't risk confusing PRs.
  3. Updates all the PDFs to use 0.1.3 generated version.

To test

  1. Switch to this branch
  2. Try npm install then grunt
  3. Verify with npm ls pdfkit that the library version is 0.1.3 and pdfkit is 0.8.3
  4. Make sure no change happens on the generated files

(Note: the "react" error in npm ls is not an issue).

folletto commented 7 years ago

Difference in PDF files:

screen shot 2017-10-20 at 17 49 59

Note that there was no rendered difference in the PDF files... still, worth checking. ;)

iamthomasbishop commented 7 years ago

Verify with npm ls pdfkit that the library version is 0.1.3 and pdfkit is 0.8.3

Looks right to me. Also seeing no changes on the generated files. Thanks for taking care of this @folletto !