search

Automattic / gridicons

The WordPress.com icon set
http://automattic.github.io/gridicons/
GNU General Public License v2.0
110 stars 13 forks source link

Updated pin icon #297

Closed SylvesterWilmott closed 6 years ago

SylvesterWilmott commented 6 years ago

Pin icon fix based on feedback here

Changes:

pin_example

folletto commented 6 years ago

SVG wise it's ok.

I'll leave to Dave for a review of the icon itself 👍

davewhitley commented 6 years ago

Thanks for the update, everything looks good. The only thing I might do is use sharp corners for the bottom part, just to align it a bit more with the rest of the set. I'll leave that up to you.

screen shot 2018-09-06 at 9 19 40 am

mattmiklic commented 6 years ago

This is purely subjective feedback but compared to #296 the vertically-oriented icon is harder to understand at a glance. By virtue of being at a 45º angle that pin fills more of the available space and looks more balanced compared to other Gridicons.

Less important but also noticed -- the blunt, rounded terminal of the pin looks weird. It's more angled and "sharp" in the original, which seems more appropriate for a pushpin.

I realize that there is a balance between consistency with our icon standards and what "looks" best so I don't feel too strongly about these opinions, but I think they're worth mentioning.

SylvesterWilmott commented 6 years ago

the blunt, rounded terminal of the pin looks weird. It's more angled and "sharp" in the original, which seems more appropriate for a pushpin.

While I was working on the icon at a magnified size the appearance of a sharp point is way nicer but at 24px the difference is negligible with the rounded version appearing more pixel sharp

This is purely subjective feedback but compared to #296 the vertically-oriented icon is harder to understand at a glance. By virtue of being at a 45º angle that pin fills more of the available space and looks more balanced compared to other Gridicons.

I'm still on the fence about this one, I understand and agree with both angled and vertical. At least for now I will merge the vertical type due to the fact that it has a lot less sub pixels and this icon should work at smaller sizes than 24px on mobile.

SylvesterWilmott commented 6 years ago

@folletto This should be good to go

folletto commented 6 years ago

The build looks good! Thanks! 👍