Closed katinthehatsite closed 1 year ago
Nice work — icons in the right place, npm run build done appropriately, all files committed. In principle this looks great! The minified SVG files testing well in Figma:
I'm seeing some weird misalignment of the PDF version, not sure why. I'm also not sure I'm testing that right, or what you could've done differently here, so it's probably fine? But if someone needs the PDF version, we can come back with a new PR and explore. The approach for it should've worked, so I'm not seeing it as a blocker.
Be aware I wasn't able to test the react component. But this seems good to go.
I would like to add a new science icon to the Gridicons. This icon will be used for staging sites when they are launched:
cc @jasmussen