Automattic / harper

The Grammar Checker for Developers
https://writewithharper.com
Apache License 2.0
2.06k stars 39 forks source link

Can't ignore `min` #287

Open benjaminjellis opened 1 week ago

benjaminjellis commented 1 week ago

Harper flags min in docs as a misspelling. However, it only provides an action to correct the spelling to minute and doesn't provide an action to add min to the global / file dictionary.

I looked through the issues and it seems to be related to https://github.com/elijah-potter/harper/issues/243, as in , that issue notes ms also cannot be added to the global / file dictionary

Screenshot 2024-11-27 at 11 43 35
grantlemons commented 1 week ago

This is because it is currently an explicit recommendation to use minute and not min, and isn't considered a spelling thing. There are a couple of changes we can probably make to improve this, but a temporary one is to add minimum as another way to correct min.

Not to be prescriptive about your comment, but the fix I would make in your shoes is just to say "minimum payment" instead of "min payment" in your doc comment, since saying that a field named min_payment is the "min payment" doesn't really clarify anything.

benjaminjellis commented 1 week ago

Thanks! The snippet is just demonstration of the issue since I can't share any real code here