search

Automattic / hidden-posts

The opposite of sticky posts.
GNU General Public License v2.0
11 stars 5 forks source link

👌 IMPROVE: Update "Requires at least" and "Tested up to" #14

Closed nielslange closed 3 years ago

nielslange commented 3 years ago

Closes #13

Change

Update WordPress version numbers for Requires at least and Tested up to.

Steps to test

  1. Install WP Downgrade | Specific Core Version plugin
  2. Downgrade core to 4.9.16, the latest version before Gutenberg was bundled
  3. Check that the Hide Post checkbox is visible in the publish section on the post edit page
  4. Downgrade core to 2.9, the version in which the action post_submitbox_misc_actions was added
  5. Check that the Hide Post checkbox is still visible
  6. Downgrade core to 2.8, the version before the action post_submitbox_misc_actions was added
  7. Check that the Hide Post checkbox is no longer visible

Note

The Tested up to cannot be bumped to 5.7, as the plugin does not support Gutenberg currently. Issue #10 had been created for that, and I'm already working on an update.

nielslange commented 3 years ago

Is there an advantage to requiring lower versions of WordPress?

Not at all. It's simply that the current information is incorrect as the plugin does not Requires at least: 3.8, but Requires at least: 2.9, given the used functions. It's not intention to encourage anyone to downgrade their WordPress version.

What happens if changes are made to the plugin down the road, would that significantly increase the amount of testing required?

I'd say it would and I plan to add both unit and e2e tests to this plugin, to detect problems automatically. Or did you mean something different?

mikeyarce commented 3 years ago

I'd say it would and I plan to add both unit and e2e tests to this plugin, to detect problems automatically. Or did you mean something different?

I think when you add support for earlier versions of WP it might make it more complicated down the road. It would be like saying "Supports IE 7" in a plugin - you're sort of committing to that and then dropping support later might be more of a burden.

For example, if you write Unit Tests you would need to make sure your Unit Tests work with WP 2.9 all the way to now, which could be a lot more work vs. the small potential reward.

htdat commented 3 years ago

For example, if you write Unit Tests you would need to make sure your Unit Tests work with WP 2.9 all the way to now, which could be a lot more work vs. the small potential reward.

Yeah, totally agree with this. I think supporting two or three latest versions of WP is sufficient. For example, Jetpack supports the latest WP core major version and one older major version. At the moment, it supports only 5.7 and 5.6 https://wordpress.org/plugins/jetpack/

I think Woo does something similar but with more older WP core versions - https://wordpress.org/plugins/woocommerce/

nielslange commented 3 years ago

Thanks for your thoughts, @htdat and @mikeyarce. I haven't seen it this way and just looked up how Jetpack, WooCommerce and Yoast are showing these informations. This is what they show:

Jetpack:

- Requires at least: 5.6 - Requires PHP: 5.6 - Tested up to: 5.7 		WooCommerce:

- Requires at least: 5.4 - Requires PHP: 7.0 - Tested up to: 5.7 		Yoast:

- Requires at least: 5.6 - Requires PHP: 5.6.20 - Tested up to: 5.7

I'll close this issue for now and will adjust the version numbers once we can create a new release. Then, I'll bump the tested and required versions up.

nielslange commented 3 years ago

Closing this issue for now based on the previous discussions.