search

Automattic / hostmgr

A tool for managing macOS VM hosts
Mozilla Public License 2.0
8 stars 3 forks source link

add BUILDKITE_LABEL and BUILDKITE_AGENT_NAME env vars to VM #18

Closed skoonin closed 2 years ago

skoonin commented 2 years ago

While working on a PR for the s3 caching plugin, I noticed these two variables weren't being passed to the VM. I believe this change should make them available in the VM.

https://github.com/Automattic/git-s3-cache-buildkite-plugin/pull/4

@jkmassel does this change just need to get merged? or does it need a manual deploy?

jkmassel commented 2 years ago

@jkmassel does this change just need to get merged? or does it need a manual deploy?

It'll need to be merged, then we'll need to cut a new version of the tool, update the homebrew reference to the new version, then we'll need to use ansible to distribute it to the nodes.

skoonin commented 2 years ago

@jkmassel does this change just need to get merged? or does it need a manual deploy?

It'll need to be merged, then we'll need to cut a new version of the tool, update the homebrew reference to the new version, then we'll need to use ansible to distribute it to the nodes.

@jkmassel sounds good, I can merge this and cut a release and will work with you to deploy it fully