search

Automattic / hostmgr

A tool for managing macOS VM hosts
Mozilla Public License 2.0
8 stars 3 forks source link

Forward additional env vars from Buildkite for Test Analytics #23

Closed mokagio closed 2 years ago

mokagio commented 2 years ago

I reported an issue in Buildkite Test Analytics where I couldn't see the build URL, number, or message in the logs, but the cause turned out to be our VM management logic 🤦‍♂️

Regardless of whether we'll move forward with adopting Test Analytics, it's worth adding those env vars.

Notice that I also took the chance to sort the array of env vars alphabetically, hopefully to make it easier to find env vars at a glance. The side effect is that the diff is harder to parse, so I recommend looking at this commit by commit.

jkmassel commented 2 years ago

I also took the chance to sort the array of env vars alphabetically, hopefully to make it easier to find env vars at a glance

Nice, thanks!!