Closed AliSoftware closed 6 months ago
Migrate all AWSResponses XML parsing from SAX (XMLParser + delegate) to DOM (XMLDocument)
XMLParser
delegate
XMLDocument
This is an approach that I've started to use when I implemented additional AWS requests for resumable upload support, and it simplifies the parsing code drastically, so I figured I'd migrate existing parsers to use this approach too.
Note: This builds on top of https://github.com/Automattic/hostmgr/pull/90 / refine-tests branch—so that we benefit from tests not referencing internal Parser implementations (that used a SAX XMLParser) anymore.
refine-tests
Migrate all AWSResponses XML parsing from SAX (
XMLParser+delegate) to DOM (XMLDocument)This is an approach that I've started to use when I implemented additional AWS requests for resumable upload support, and it simplifies the parsing code drastically, so I figured I'd migrate existing parsers to use this approach too.
Note: This builds on top of https://github.com/Automattic/hostmgr/pull/90 /
refine-testsbranch—so that we benefit from tests not referencing internal Parser implementations (that used a SAXXMLParser) anymore.