Consider changing localeSlug to lang

Automattic / i18n-calypso

i18n JavaScript library on top of Jed originally used in Calypso

GNU General Public License v2.0

24 stars 19 forks source link

Open atimmer opened 8 years ago

atimmer commented 8 years ago

The attribute for specifying the language to Jed is lang inside the meta object. On https://github.com/Automattic/i18n-calypso/blob/master/lib/index.js#L177 localeSlug is assumed which requires more attribute juggling when a json from a tool such as po2json is used.

It would be better to change this to lang to be compatible with Jed.

ryerh commented 7 years ago

If this is a feature, should it be listed in README?