search

Automattic / i18n-calypso

i18n JavaScript library on top of Jed originally used in Calypso
GNU General Public License v2.0
24 stars 19 forks source link

Drop Moment and Moment Timezone #61

Open blowery opened 6 years ago

blowery commented 6 years ago

We're not supplying any custom translations for these and having them as dependencies forces them on clients of this module. Both are quite large when bundled with webpack and would be better included by a client project if they wish to use them.

beaucollins commented 6 years ago

At the very least relax the version requirement. We're using i18n-calypso in a project that also uses moment-timezone and now we have two moment-timezones:

pasted_image_8_24_18__9_40_am

moment-timezone@^0.5 seems reasonable.

beaucollins commented 6 years ago

I see #65 already deletes the dependency now!