Remove moment and moment-timezone from i18n-calypso

Automattic / i18n-calypso

i18n JavaScript library on top of Jed originally used in Calypso

GNU General Public License v2.0

24 stars 19 forks source link

Remove moment and moment-timezone from i18n-calypso #65

Closed blowery closed 5 years ago

blowery commented 6 years ago

Clients will now need to require them themselves to use them. This frees up clients of i18n-calypso to load moments translations and timezone data any way they see fit, or to not use moment at all.

sirreal commented 6 years ago

👍 for v3 (alpha)
Does bundling moment provide any value beyond just providing the module?
How do you see this moving forward? Should we open a v3 branch that can receive merges from master to maintain them in parallel? next dist-tag on npm?

ockham commented 6 years ago

I haven't released v2 yet (nor have I merged #64), so we can still include this change in it.

blowery commented 6 years ago

Does bundling moment provide any value beyond just providing the module?

I think bundling moment actively hurts clients of i18n-calypso. So, no. :) I wouldn't recommend anyone depend on it.

blowery commented 6 years ago

I haven't released v2 yet (nor have I merged #64), so we can still include this change in it.

I'd be ok with that.

blowery commented 6 years ago

Fixes #61

mhsdef commented 6 years ago

Make y'all a deal -- merge this, I'll Flow type the package and submit a libdef to https://github.com/flow-typed/flow-typed.

blowery commented 6 years ago

@hewsut :D

sirreal commented 6 years ago

Is there really anything left to do here other than rebase and put this on a v3 branch so v2 can continue to be maintained in parallel? This seems fine for an alpha.

Then we could see about releasing that to npm, optionally with a next dist-tag (being carefuly not to latest tag it).

@hewsut Care to tackle any of that? 😁

blowery commented 5 years ago

Closing until we get this moved into the calypso repo