Automattic / i18n-calypso

i18n JavaScript library on top of Jed originally used in Calypso
GNU General Public License v2.0
24 stars 19 forks source link

Switch to hash.js from sha1 #67

Closed blowery closed 6 years ago

blowery commented 6 years ago

hash.js, using just sha1 is 2.3k gzipped, while sha1 is 8k.

Switch to save some bytes and align with what calypso uses.

blowery commented 6 years ago

Testing... Yeah.

The existing unit tests sort of cover this, but there are no tests (that I can find) that explicitly cover the caching bit. I'll see if I can work something up.

blowery commented 6 years ago

@sirreal added tests for hashed lookups. They pass on master as well as here.