Automattic / i18n-calypso

i18n JavaScript library on top of Jed originally used in Calypso
GNU General Public License v2.0
24 stars 19 forks source link

fix(deps): update dependency jed to v1.1.1 #72

Closed renovate[bot] closed 6 years ago

renovate[bot] commented 6 years ago

Additions by @ockham:

Closes #19

To verify that test modifications are legit, compare to https://github.com/messageformat/Jed/pull/33/files, where they also removed all the first values in test arrays (mostly nulls, but some actual string values in pluralization examples).

~Will need D19382-code before we can update Calypso to use this.~ D19382 is now merged!

Original PR desc below.


This PR contains the following updates:

Package Type Update Change References
jed dependencies minor 1.0.2 -> 1.1.1 source

Release Notes

SlexAxton/Jed ### [`v1.1.1`](https://renovatebot.com/gh/SlexAxton/Jed/compare/1.1.0...1.1.1) [Compare Source](https://renovatebot.com/gh/SlexAxton/Jed/compare/1.1.0...1.1.1) ### [`v1.1.0`](https://renovatebot.com/gh/SlexAxton/Jed/compare/1.0.2...1.1.0) [Compare Source](https://renovatebot.com/gh/SlexAxton/Jed/compare/1.0.2...1.1.0)

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


This PR has been generated by Renovate Bot. View repository job log here.

ockham commented 6 years ago

Relevant: #19 https://github.com/messageformat/Jed/pull/33

/cc @tyxla

ockham commented 6 years ago

Looking into fixing this now

renovate[bot] commented 6 years ago

PR has been edited

:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

ockham commented 6 years ago

Don't merge yet, we still need to fix the generated translation (.js, .json) files. Probably some script in this repo.

ockham commented 6 years ago

Translation generator script fix (WIP): D19319-code

tyxla commented 6 years ago

Noting that I've tested D19319-code and it looks good! This one also looks good, code-wise.

ockham commented 6 years ago

Updated translation generator fix: D19382-code (retains current translation files for backwards compat with existing clients, adds -v1.1 ones).

ockham commented 6 years ago

This probably needs a major release, since it breaks compat of translation files.

ockham commented 6 years ago

Let's ship 2.0.2 first tho I guess? (#79)

ockham commented 6 years ago

Rebased