Automattic / jetpack-boost-critical-css-gen

Critical CSS Generator built for Jetpack Boost
Other
13 stars 5 forks source link

[Boost] Prevent bad URLs from breaking Critical CSS Generator #44

Open thingalon opened 4 months ago

thingalon commented 4 months ago

Related: https://github.com/Automattic/jetpack/pull/35561

If a bad URL gets fed into one Critical CSS provider, the whole process fails with a meaningless error:

Failed to construct 'URL': Invalid URL

If parsing a URL fails, it should throw a provider-specific error message, and specify what URL was invalid.

alinclamba commented 4 months ago

When this fix will be released, would be nice to let the user know, so adding the Zendesk ticket here as a reminder: 7710563-zd-a8c