search

Automattic / jetpack-onboarding

Jetpack Onboarding
50 stars 5 forks source link

Themes screen does not load themes that are not installed #6

Open MikeHansenMe opened 10 years ago

MikeHansenMe commented 10 years ago

Currently when you get to the theme selection screen you see this. Only themes that are installed show up.

jps-themes

georgestephanis commented 10 years ago

@lezama Can we pass in preview screenshots and the like so that themes could be installed on demand during Start, for premium themes, generic .org themes, and the like?

lezama commented 10 years ago

@georgestephanis Yes we can. IMHO I think that it will make the user experience less smoother. It is possible to set the themes shown on that step with the jetpack_start_themes filter https://github.com/Automattic/jetpack-start/blob/master/steps/select-theme.php#L47. My suggestion is to have the themes shown on that step preinstalled if possible.

MikeHansenMe commented 10 years ago

Small addition. Users can view the preview since that is just a link but if they then select a theme based on the preview they get a whitescreen on the frontend because the theme does not exist.

georgestephanis commented 10 years ago

Yes, sorry, I had figured for non-installed themes, it would link to an external demo site. Like https://twentythirteendemo.wordpress.com or the like.