Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 798 forks source link

Settings: make 'setting saved' messages customized per feature #10640

Open rickybanister opened 5 years ago

rickybanister commented 5 years ago

Currently when you activate a feature you see a generic message like this:

image

I would like to explore the possibility of customizing those messages for each feature. Especially features like our file and image cdn, where activation has no tangible or noticeable effect on the site.

In that case we'd display a message like:

Site accelerator is now speeding up your site!

@dereksmart is that currently easy to do?

jeffgolenski commented 5 years ago

Here's a terrible mockup to communicate the "After" of this:

screen shot 2018-12-06 at 10 39 30 am
jeffgolenski commented 5 years ago

@oskosk @jeherve per a conversation I had with @dereksmart - I'm just adding you both here.

oskosk commented 5 years ago

Work in Progress here: #10972

oskosk commented 5 years ago

@jeffgolenski the PR #10972 moves some internal structure to favor the addition of more custom messages. And it also adds a custom message JUST for the site accelerator toggle. I think it could be good to go with that PR first and then work with other messages for other features. But if we have already an idea of what other messages we want, we can go as you wish.

I'm stating this because your proposal for publicize, is from the kind that seems that could be automated: "Updating xxxx settings". But Rick's proposal is a very custom one. Take in account that we have success, failure, and in progress messages. And also, some of the features are about activation or deactivation.... Which, like in the message Rick proposes, these messages can provide more room for statements of victory from enabling our features.

oskosk commented 5 years ago

~There's currently some glitch with the site accelerator toggling which would show the notice twice because it's actually doing two requests in the background. Will address soon~ Addressed in 6f4e89336e9a02f7b52e236c026d5f71e5bb7f41

rickybanister commented 5 years ago

@jeffgolenski to jump on @oskosk's very astute comment—I would definitely like custom messages, not just including the feature or module's name there. The goal is to show customers what will change, how enabling this or that thing will specifically add value.

The work for the design team to do is to work through the various settings and determine what those messages should be. For some it may be simple and not require much customization (like spell check options updated) and for others, like the example in the original post that Osk pointed to should be much more tailored.

Can we take a stab at crafting those messages and pull in editorial? It's fine if that happens next week obviously.

oskosk commented 5 years ago

How about if we work on this in the following way.

  1. I go and create the structure for custom messages, card by card, or tab by tab using boilerplate message strings.
  2. Then, leave the PR there with a hopefully clear way to just update the strings, and we work together with editorial from there on.
  3. In the meantime I can go and create other PRs like in (1).

Even if probably fluid, one downside of this proposal ^ is that by having the designed messaging live only here in PRs, we won't probably offer a comprehensive view of the general communication intent to others not working directly on GitHub.

oskosk commented 5 years ago

The PR that introduced the first changes mentioned here is already merged. ( #10972 ). Should we close this issue and come up with a new one ? cc @joanrho

Moved this issue into the "Jetpack Dashboard" column.

jeffgolenski commented 5 years ago

@oskosk Thanks for building this out!

We'll leave this issue open since we need to follow through and add this functionality for every toggle in the settings area, not just the accelerator. That's step 1.

We'll then create a new issue for what Rick mentions above for our step 2. This way we have smaller iterative chunks and not a crazy PR.

Do you concur, @keoshi @joanrho ?

keoshi commented 5 years ago

Sounds good to me!

jeffgolenski commented 5 years ago

Creating a master doc with the messaging here: https://docs.google.com/document/d/1Vp637qyWUlj_P3f7HOq3TnulumTi9mhMGBWNQ8586j4/edit?usp=sharing

Will comment on this thread once finished

jeffgolenski commented 5 years ago

@joanrho @rickybanister @oskosk @keoshi The "Performance" section verbiage is now ready for a review in the document above. ^^

joanrho commented 5 years ago

@jeffgolenski Thanks for working on those—they LGTM!

jeffgolenski commented 5 years ago

@oskosk Do you want to spin up a PR to begin working on the performance tab settings changes mentioned above, while I continue to write the other sections?

jeffgolenski commented 5 years ago

I've completed the settings message for every place within wp-admin. Performance, Writing, Sharing, Discussion, Traffic, and Security settings toggles.

@benhuberman Could you or someone on your team give this a quick gander and let me know if you have any grammar or style tweaks we need to make?

https://docs.google.com/document/d/1Vp637qyWUlj_P3f7HOq3TnulumTi9mhMGBWNQ8586j4/edit#

Basically, we're updating the Enable / Disable messages when a customer toggles them on your off. Example:

Enable: “Enabling site accelerator...” Enabled: “Site accelerator is now speeding up your site!” Disable: “Disabling site accelerator...” Disabled: “Site accelerator is no longer speeding up your site.”

@joanrho @rickybanister @keoshi When you all get back online from break, let me know what you think

benhuberman commented 5 years ago

I just went through the doc and left comments/suggested edits there, @jeffgolenski.

jeffgolenski commented 5 years ago

Thanks so much @benhuberman I updated everything accordingly and left one comment for your thoughts.

benhuberman commented 5 years ago

Just responded to your comment, @jeffgolenski. For future reference, I see your point about keeping "WordPress.com Secure Sign On" as-is in the copy as long as that's the official feature name, though as I also noted, it would be great to move on from this name sooner rather than later, as "sign on" is quite different from "sign in" or "log in," and I worry that it doesn't really tell users what this is about.

jeffgolenski commented 5 years ago

@benhuberman Touché sir! I agree!

jeffgolenski commented 5 years ago

@oskosk Just wondering if we have the capacity to pick this back up again for an upcoming release? We've got all the strings sorted in the doc above, just need to start making it happen.