Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 797 forks source link

iFrame Validation errors #1071

Open mayeenulislam opened 10 years ago

mayeenulislam commented 10 years ago

I'm using Facebook Like Box by JetPack, and with W3C Validator I'm getting the following two errors regarding iframe: w3c validation error on iframe

The result can be seen here: http://validator.w3.org/check?uri=http%3A%2F%2Fnishachor.com%2F&charset=%28detect+automatically%29&doctype=Inline&ss=1&outline=1&group=1&No200=1&verbose=1&st=1&user-agent=W3C_Validator%2F1.3+http%3A%2F%2Fvalidator.w3.org%2Fservices

mayeenulislam commented 10 years ago

And W3C Mobile Validator is saying: W3C Mobile validator's say on iframe

And it's a critical issue of a site.

kraftbj commented 10 years ago

For the mobile issue, the iframe is the only way to deliver the information from Facebook. The mobile validator, I assume, is referring to the old practice of using HTML frames or an iframe to display primary content surrounded by "fixed" elements.

For the obsolete HTML, we'll take a look.

jeherve commented 10 years ago

We might be able to use the HTML5 embed code instead of the iFrame, but I'll have to check if that method still provides the same options.

jeherve commented 9 years ago

Similar issue with the Jetpack Comment form.

Reported here: https://wordpress.org/support/topic/please-fix-w3-validation-errors?replies=1&view=all

aheckler commented 9 years ago

Mentioned in 2143459-t

jeherve commented 8 years ago

Also reported here: https://wordpress.org/support/topic/w3c-errors-5?replies=1&view=all

jeherve commented 8 years ago

The Facebook Like Box was deprecated by Facebook, and we now use the Facebook Page Plugin instead: https://developers.facebook.com/docs/plugins/page-plugin

Sine the new Page Plugin doesn't use an iFrame, this issue only concerns the Comment form now.

jeherve commented 7 years ago

Also reported here: https://wordpress.org/support/topic/reddit-share-button-generates-w3c-errors/

seejacobscott commented 6 years ago

Also reported in 755768-zen referencing the Contact Info and Map widget:

The frameborder attribute on the iframe element is obsolete. Use CSS instead.

Tested on https://validator.w3.org/

stale[bot] commented 6 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

github-actions[bot] commented 3 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.