Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.57k stars 796 forks source link

Pass locale to PayPal script in SimplePayments buttons #11160

Open simison opened 5 years ago

simison commented 5 years ago

Is your feature request related to a problem? Please describe.

Simple Payment button loads PayPal checkout script and passes some settings to it. We do not pass a locale, which would probably tell PayPal to output the payment button in different languages.

Describe the solution you'd like

Pass locale to PayPal here:

https://github.com/Automattic/jetpack/blob/48db8b56a1f81cf31a2dd2982d08cbe4497e8f7f/modules/simple-payments/paypal-express-checkout.js#L137-L147

See documentation: https://developer.paypal.com/docs/checkout/integrate/#1-get-the-code Supported locales: https://developer.paypal.com/docs/integration/direct/rest/locale-codes/

Additional context

p1547804273386000-slack-jpop-support

cc @rodrigoi

coder-karen commented 5 years ago

To add to the above, this issue was initially brought up in 1727921-zen

khristiansnyder commented 5 years ago

+1-Another request for this in 11075062-hc

stale[bot] commented 4 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.