Properly escape attr_esc( json_encode( $data ) )

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.58k stars 797 forks source link

Properly escape attr_esc( json_encode( $data ) ) #1170

Open enejb opened 9 years ago

enejb commented 9 years ago

Currently we are not doing it right and we could be introducing bugs for people that are not on PHP 5.3 or higher. See shortcode/slideshow.php line 211 for an example how to do it right. https://github.com/Automattic/jetpack/blob/master/modules/shortcodes/slideshow.php#L211

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

It has been inactive in the past 6 months.
It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.