search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Debugger / Site Health Displaying False-Positive Errors #12881

Closed htdat closed 4 years ago

htdat commented 5 years ago

Purpose of this GitHub issue

Details of the issue.

0cb8ff40c8f9b125efddbb54ce7f727e

What to report

Other info

Originally in 3927-gh-jpop-issues

anaemnesis commented 5 years ago

Ticket: 2169467-zen Jetpack debug: Everything looks great! Site ID: 148793315 Connection test:

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
ntpixels commented 5 years ago

Ticket: 2202245-zen Jetpack debug: Everything looks great! Site ID: 164759548 Connection test:

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

pranali333 commented 5 years ago

Ticket: 2213829-zen Jetpack debug: Everything looks great! Site ID: 163415962 Connection test:

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

htdat commented 5 years ago

Tix: 2250241-zen Jetpack debug: Everything looks great! Site ID: 158699724

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detect\u00f3 un error.","resolution":"Visita la p\u00e1gina de depuraci\u00f3n de Jetpack.com para m\u00e1s informaci\u00f3n o contactar con soporte.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
a8ck3n commented 5 years ago

Ticket: 2254863-zen Jetpack debug is good. Site ID: 41160620

cxn_tests: {'9':{'name':'test__wpcom_self_test','pass':false,'message':'Jetpack.com detected an error.','resolution':'Visit the Jetpack.com debugging page for more information or contact support.','action':false,'severity':'critical','group':['default'],'type':'direct'}}
dericleeyy commented 5 years ago

Ticket: 2272084-zen

Jetpack Debug is good.

Site ID: 155898264

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
htdat commented 5 years ago

2290973-zen Jetpack Debug is good. Site ID: 120401281

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
anaemnesis commented 5 years ago

2299364-zen Jetpack Debug is good Site ID: 165021488

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
coder-karen commented 5 years ago

2290680-zen Jetpack Debug is good Site ID: 143332086

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
lizthefair commented 5 years ago

Ticket: 2312741-zen Jetpack Debug status: Everything looks great! Site ID (blog_id): 82368205

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

anaemnesis commented 5 years ago

Ticket: 2317282-zen Jetpack Debug: Everything looks great! Site ID: 103873295 Connected via REST.

cxn_tests: 
{'9':{'name':'test__wpcom_self_test','pass':false,'message':'Jetpack.com 
detectu00f3 un error.','resolution':'Visita la pu00e1gina de depuraciu00f3n de 
Jetpack.com para mu00e1s informaciu00f3n o contactar con 
soporte.','action':false,'severity':'critical','group':['default'],'type':'direct'}}
aheckler commented 5 years ago

2318941-zen Debug OK Site ID: 67178716 Connected via REST cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

htdat commented 5 years ago

@aheckler and @jeremypaavola - Site ID and JPDB result are good enough. Avoid providing site URLs in this public issue ;)

mdrovdahl commented 5 years ago

Note: this is a Team51 site Slack: p1567620876088300-slack-jpop-support Debug OK Site ID: 162042271 Connected via XML-RPC {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

htdat commented 5 years ago

Updating the priority to [Pri] Normal as we have more and more reports.

anaemnesis commented 5 years ago

2328536-zen Debug OK Site ID: 112133580 Connected via REST cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

anaemnesis commented 5 years ago

2329845-zen Debug: 503 due to a CF block on /xmlrpc.php?for=jetpack (but not on /xmlrpc.php) Site ID: 103947952 Connected via XML-RPC (but not really) {'9':{'name':'test__wpcom_self_test','pass':false,'message':'Jetpack.com detected an error.','resolution':'Visit the Jetpack.com debugging page for more information or contact support.','action':false,'severity':'critical','group':['default'],'type':'direct'}}

anaemnesis commented 5 years ago

324579-zen Debug: OK Site ID: 137516216 Connected via XML-RPC cxn_tests: All Pass.

aheckler commented 5 years ago

2328310-zen ID: 121282792 Debug: OK Connected via REST. cxn_tests: {"7":{"name":"test__wpcom_connection_test","pass":false,"message":"blue dirt girl - original indie band from vancouver is not connected.: 200","resolution":"Please contact Jetpack support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

julsyd commented 5 years ago

Ticket: 2343601-zen ID: 162687667 Debug: OK

Connection Tests {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com a d\u00e9tect\u00e9 une erreur.","resolution":"Visitez la page de d\u00e9bogage de Jetpack.com pour en savoir plus ou contactez l'assistance.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
anaemnesis commented 5 years ago

2341843-zen Debug: OK Site ID: 151135806 {'9':{'name':'test__wpcom_self_test','pass':false,'message':'Jetpack.com detected an error.','resolution':'Visit the Jetpack.com debugging page for more information or contact support.','action':false,'severity':'critical','group':['default'],'type':'direct'}}

chaselivingston commented 5 years ago

2360289-zen Debug ok Site ID: 137938645

Connection Tests

{"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
kraftbj commented 5 years ago

I'd like to see if we can break up this issue some.

test__wpcom_self_test -- this is the same as when the SELF test failed on the old in-plugin debugger. The Jetpack site pings wp.com and requests WP.com run the Jetpack debugger, then handles the response as long as it comes back within 30 seconds. If it takes longer than 30 seconds, it'll fail. A potential resolution is to provide a middle state ("Test did not respond in time.").

test__wpcom_connection_test -- this one is stating that the /jetpack-blogs/%d/test-connection endpoint did not think the site was connected. Maybe confirm the URLs are what is expected?

kraftbj commented 5 years ago

13530 would eliminate times when the self test would fail out due to a timeout, which is a known false error state. Going to see if that alone is enough to generally reduce/eliminate false positives. Marked for 7.9 (Nov '19) release.

cena commented 5 years ago

238828-zen JP DB: Everything looks great! Site ID: 164977491

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

anaemnesis commented 5 years ago

2401729-zen Debug: OK Site ID: 123989187 Connected via XML-RPC

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}

kraftbj commented 5 years ago

For the purposes of the issue, I don't think we need any additional reports until sites are running 7.9 and we can determine if there are cases not covered by the existing fix.

joendotcom commented 5 years ago

2409631-zen Everything looks great! 44649782

cxn_tests: {"9":{"name":"test__wpcom_self_test","pass":false,"message":"Jetpack.com detected an error.","resolution":"Visit the Jetpack.com debugging page for more information or contact support.","action":false,"severity":"critical","group":["default"],"type":"direct"}}
RCowles commented 5 years ago

Also reported in 2463999-zen, user on Jetpack 7.8.

coder-karen commented 5 years ago

User on 7.9, Site Health reports a curl 28 timeout error. All tests pass in the debugger. 2468476-zen

kraftbj commented 5 years ago

The loopback request mentioned in the ticket is from Core -- their site did not respond to a request to itself as expected ( https://github.com/WordPress/WordPress/blob/f1b5f2aa94c45aa087e96ac91ca53d241ee3146b/wp-admin/includes/class-wp-site-health.php#L1642 ).

The http_request_failed test means that their site did not get a response back from something within 10 seconds, but it isn't clear in the ticket from what.

All in all, I think that is the site debug working as expected. It isn't a false positive error -- loopback isn't working as expected and whatever the http request, it was expecting to get a response back within 10 seconds and didn't. That could indicate the test is expecting something too quickly or network issues between the Jetpack site and the server, etc. I think this site is just slow.

tmmbecker commented 4 years ago

2496139-zen JP 7.9.1 Debug is great. Self-test is failing.

htdat commented 4 years ago

2514574-zen JP 7.9.1 blog_id = 73509231 Debug is great. Self-test is failing.

aicee commented 4 years ago

2525376-zen JP: 7.9.1 blog_id = 162706612 Debug is great. Self-test is failing.

htdat commented 4 years ago

@kraftbj - We're seeing more and more reports. Do you think we should report this in a separate issue?

htdat commented 4 years ago

2535860-zen JP 8.0 blog_id = 157196708

aicee commented 4 years ago

2535296-zen JP 7.9.1 blog_id = 51124069 Debug is great. Self-test is failing.

madhattermattic commented 4 years ago

2535251-zen JP 8.0 Blog ID: 156763502 Debug is great. Self-test is failing.

htdat commented 4 years ago

2531506-zen JP 8.0 Blog ID: 169763173 Debug is great. Self-test is failing.

tmmbecker commented 4 years ago

2534598-zen Self-test is failing and user-facing debugger is showing Could not fetch data. JP 8.0

csonnek commented 4 years ago

2540352-zen JP 8.0 Self-test failing Debug OK (both for Super admin and user-facing) - blog ID 169685843

kraftbj commented 4 years ago

Going to just not run the self test and moving forward with using the newer suite.

bhoop commented 4 years ago

2543967-zen JP 8.0 Self-test failing Debug is great

kraftbj commented 4 years ago

No need to keep reporting these.

chaselivingston commented 4 years ago

@kraftbj Just saw another instance of this in 2601672-zen using Jetpack 8.0. Should this still be happening or do you think there's a new problem?

csonnek commented 4 years ago

@kraftbj I have one in 2615740-zen as well.

The Site Health plugin is listing JetPack as having a Critical Issue. Specifically, it says, 'Jetpack.com detected an error on the WPcom Self Test.' When I click the link to debug it, it says, 'Debug Unknown error An unknown error has occurred.'

They're on 8.0 and the debug is OK.

kraftbj commented 4 years ago

@chaselivingston & @csonnek Pulling out the old debugger is coming in Jetpack 8.1 and converting the server-side old debugger to use the new suite is pending review in D37439

nielslange commented 4 years ago

Another report in

17798236-zen 2630165-hc

druesome commented 4 years ago

Seeing this happening consistently in Atomic sites atm. When running jetpack status, common error message is:

test__wpcom_self_test: Jetpack.com detected an error on the WPcom Self Test.

Disconnecting and reconnecting doesn't help.

2629897-zen

kraftbj commented 4 years ago

This issue should remain closed and any others should have a new ticket. The impacted test was removed in #14198, but that code didn't ship until 8.1 (today). If there are still issues, please confirm they are not running an older version. If they are running 8.1 or higher, please open a new issue as it is not related to this one since the test is no longer running by default (requires a filter to enable it currently).