Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Composer install of 7.6 fails due to reliance on dev package. #13382

Closed peterwilsoncc closed 3 years ago

peterwilsoncc commented 5 years ago

Composer installs are currently defaulting to Jetpack 7.4.1 due to later packages having @dev dependencies with "minimum-stability": "dev",.

Composer inherits the minimum stability from the parent package.

Steps to reproduce the issue

  1. Initialise a composer config
  2. Run composer require "automattic/jetpack *"
  3. Composer will install from the 7.4 branch as that is the latest branch with stable packages.
  4. Run composer require "automattic/jetpack 7.6"
  5. Composer will refuse to upgrade as Jetpack uses a dev release:
    
    composer require "automattic/jetpack 7.6"

./composer.json has been updated Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages.

Problem 1

Potential causes:

Read https://getcomposer.org/doc/articles/troubleshooting.md for further common problems.


Note: My package does not have a minimum stability setting so the second suggested cause comes from composer default settings. 

#### What I expected
<!-- A clear and concise description of what you expected to happen. -->
Jetpack to install the latest release using stable dependencies. 

#### What happened instead
Jetpack 7.4.1 installed.
jeherve commented 5 years ago

Related: #12680

stale[bot] commented 4 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

jeherve commented 4 years ago

We're still working on this. #14964 is what we are currently working on.

stale[bot] commented 4 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

jeherve commented 3 years ago

This can now be closed, as it was handled via Changelogger and the autotagger tool added in #19192. Our packages' stable versions now always rely on stable packages.