search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 797 forks source link

General: Please add the following bots to jetpack #1402

Closed nitinthewiz closed 9 years ago

nitinthewiz commented 9 years ago

Hi,

I'm not sure how to do a pull request on this repo, since I'm not able to create a branch here. But I just want you folks to extend the list of bots that jetpack recognizes. To do that, please extend the class.jetpack-user-agent.php file with the following array - 

$bot_agents = array(
            'alexa', 'altavista', 'ask jeeves', 'attentio', 'baiduspider', 'bingbot', 'chtml generic', 'crawler', 'fastmobilecrawl',
            'feedfetcher-google', 'firefly', 'froogle', 'gigabot', 'googlebot', 'googlebot-mobile', 'heritrix', 'ia_archiver', 'irlbot',
            'infoseek', 'jumpbot', 'lycos', 'mediapartners', 'mediobot', 'motionbot', 'msnbot', 'mshots', 'openbot',
            'pss-webkit-request',
            'pythumbnail', 'scooter', 'slurp', 'snapbot', 'spider', 'taptubot', 'technoratisnoop',
            'teoma', 'twiceler', 'yahooseeker', 'yahooysmcm', 'yammybot', 'ahrefsbot', 'pingdom.com_bot', 'kraken', 'yandexbot', 
            'twitterbot', 'tweetmemebot', 'openhosebot', 'queryseekerspider', 'linkdexbot', 'grokkit-crawler',
            'livelapbot', 'germcrawler', 'domaintunocrawler', 'grapeshotcrawler', 'cloudflare-alwaysonline',
        );

Notes on this edit are on my blog here.

Thanks! Nitin

enejb commented 9 years ago

Hi nitinthewiz,

Thanks for reporting the issue and the blog post. The list of bots is very helpful as well.

To learn how to create a pull request you can follow these steps. https://help.github.com/articles/creating-a-pull-request/ I think you mentioned that you created a fork. Then you are half way there. :)

In the mean time I create a PR that will allow users to add their own list of bots. You can find it here. https://github.com/Automattic/jetpack/pull/1403

nitinthewiz commented 9 years ago

@enejb Thanks for your help. I believe I've found the right doc for fork+pull requests (https://help.github.com/articles/using-pull-requests/#before-you-begin) and will use it next time.

Meanwhile, your filter method is definitely the better way forward and I can't wait to use it in the next jetpack version. Thanks! :+1:

jeherve commented 9 years ago

@nitinthewiz You can also follow the steps here to create a Pull Request for Jetpack ;) http://jetpack.me/contribute/#patch