Redirect Everything project - Githubissues

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.59k stars 797 forks source link

Redirect Everything project #15403

Open leogermani opened 4 years ago

leogermani commented 4 years ago

This issue tracks what is still to be done in the Redirect Everything project after its first PR is merged.

More context on: 1151641796826042-as-1162696453656729

Finish Linters

[ ] JS Linter
[ ] PHP Linter

Finish redirect on js side

[x] Finish and deploy the npm package
[x] Make the function always send the current site url by default
[x] Use npm package in blocks -> finish this PR
[x] Make all JS links use the npm package and delete the helper function from client libs

These files need special attention:

[ ] /_inc/client/plans/feture-item.jsx
[ ] /_inc/client/traffic/related-posts.jsx
[ ] /extensions/shared/components/upgrade-nudge/index.jsx
[ ] /extensions/shared/plan-upgrade-notification.js
[ ] /extensions/shared/test/get-validated-attributes.js
[ ] /modules/plugin-search/plugin-search.js
[ ] /modules/search/instant-search/components/jetpack-colophon.jsx
[ ] /tools/jetpack-live-branches/jetpack-live-branches.user.js

Handle edge cases

[ ] handle localized URLs on the server side, by getting blog settings in the cache site
[ ] do the same to handle currency
[ ] Handle checkout URLs
[ ] Remove URLs from i18n strings (remember to add rel="noopener noreferrer" in links inside i18n strings when needed)

List of PHP files with links to either https://jetpack.com or https://wordpress.com that need to be redirected:

[ ] /_inc/class.jetpack-provision.php
[ ] /_inc/lib/components.php
[ ] /3rd-party/class.jetpack-amp-support.php
[ ] /3rd-party/vaultpress.php
[ ] /class.jetpack.php
[ ] /functions.photon.php
[ ] /jetpack.php
[ ] /modules/calypsoify/class.jetpack-calypsoify.php
[ ] /modules/carousel/jetpack-carousel.php
[ ] /modules/minileven.php
[ ] /modules/plugin-search.php
[ ] /modules/protect.php
[ ] /modules/sitemaps/sitemap-builder.php
[ ] /modules/sitemaps/sitemap-stylist.php
[ ] /modules/subscriptions/views.php
[ ] /modules/theme-tools/site-breadcrumbs.php
[ ] /modules/theme-tools/site-logo.php
[ ] /modules/videopress/class.jetpack-videopress.php
[ ] /modules/widgets/simple-payments/admin-warning.php
[ ] /packages/backup/src/class-helper-script-manager.php
[ ] /packages/jitm/src/class-jitm.php
[ ] /tests/php/general/test_class.jetpack.php
[ ] /tests/php/general/test-class.jetpack-gutenberg.php
[ ] /tests/php/modules/shortcodes/test-class.gist.php

kraftbj commented 4 years ago

We need to add an issue to make the package able to work on WP.com without redirecting folks to jetpack.com and then back. I'm not sure the best solution:

Add a filter to the package to change the redirect URL from jetpack.com/redirect/ to something new at wordpress.com/, while extending the server-side stuff to work with it.
Add a filter to provide the direct URL as returned from the system so that we bypass any redirect.

This is a Fusion blocking issue.