search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Highlander: Facebook comment: Broken avatar #15519

Open scruffian opened 4 years ago

scruffian commented 4 years ago

When leaving a comment using Highlander, if I connect with Facebook, I see a broken avatar:

Screenshot 2020-04-22 at 12 19 40

Steps to reproduce the issue

  1. Go to a post that has Highlander comments enabled
  2. Click on "Enter you comment here"
  3. Click on the Facebook logo
  4. Authenticate with Facebook where necessary
  5. Notice that the avatar for your Facebook user doesn't show

What I expected

I expected to see my Facebook avatar

What happened instead

I saw a broken image

Screenshots

Screenshot 2020-04-22 at 12 19 40
jeherve commented 4 years ago

Does this happen in a specific browser, or all of them? Can you spot any JS error in the JavaScript console?

scruffian commented 4 years ago

It happens in Chrome incognito mode. Not tried any others yet.

There is a JS error:

Screenshot 2020-04-22 at 14 26 06
glendaviesnz commented 4 years ago

This is mostly likely because of an issue with permission on the Facebook API which has been around for about a year at least "Facebook Platform" "invalid_request" "(100) Only owners of the URL have the ability to specify the picture, name, thumbnail or description params." - it is not letting us get the picture anymore because we haven't validated the domain or something. We are currently tracking the overall API problem in another issue, but will link to this issue so we can make sure we test and close off this avatar issue when the API permissions are resolved.

davemart-in commented 4 years ago

Let's hide the avatar if Facebook is being used to authenticate.